[FIX] Another color palette when too many colors needed #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerneju
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2522 +/- ##
==========================================
+ Coverage 75.11% 75.13% +0.02%
==========================================
Files 323 324 +1
Lines 56902 56956 +54
==========================================
+ Hits 42743 42796 +53
- Misses 14159 14160 +1 |
janezd
requested changes
Aug 18, 2017
| self.colors = colorpalette.ColorPaletteGenerator( | ||
| N, colorbrewer.colorSchemes["qualitative"]["Dark2"]) | ||
| N, scheme) |
| classification.NaiveBayesLearner(), | ||
| classification.SGDClassificationLearner() | ||
| ] | ||
| return evaluation.CrossValidation(data, learners, k=2, store_data=True) |
There was a problem hiding this comment.
Rename common.py to base.py. Instead of function color_palette_test, base.py should include a class derived from WidgetTest with a method test_many_evaluation_results. TestOWROCAnalysis, TestOWCalibrationPlot and TestOWLiftCurve are then derived from this class.
| @@ -49,3 +50,11 @@ def test_nan_input(self): | |||
| self.assertTrue(self.widget.Error.invalid_results.is_shown()) | |||
| self.send_signal(self.widget.Inputs.evaluation_results, None) | |||
| self.assertFalse(self.widget.Error.invalid_results.is_shown()) | |||
|
|
|||
| def test_many_evaluation_results(self): | |||
There was a problem hiding this comment.
Remove this method (inherit it from the base class).
| @@ -51,3 +52,11 @@ def test_nan_input(self): | |||
| self.assertTrue(self.widget.Error.invalid_results.is_shown()) | |||
| self.send_signal(self.widget.Inputs.evaluation_results, None) | |||
| self.assertFalse(self.widget.Error.invalid_results.is_shown()) | |||
|
|
|||
| def test_many_evaluation_results(self): | |||
There was a problem hiding this comment.
Remove this method (inherit it from the base class).
janezd
approved these changes
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Similar as in #2394. This time fixed in widgets Calibration Plot and Lift Curve.
Additional info: https://sentry.io/biolab/orange3/issues/210623933/
Description of changes
Same solution as in #2394.
Three tests use the same code and that is why that code is moved to a separate file.
Includes