[FIX] Fix failing report tests #2574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerneju
referenced
this pull request
Sep 11, 2017
Codecov Report
@@ Coverage Diff @@
## master #2574 +/- ##
==========================================
- Coverage 75.02% 75.02% -0.01%
==========================================
Files 327 327
Lines 57641 57641
==========================================
- Hits 43248 43244 -4
- Misses 14393 14397 +4 |
astaric
reviewed
Sep 11, 2017
| root = root[len(top_module.__path__[0]):].lstrip(os.path.sep) | ||
| for file in files: | ||
| if file.lower().startswith('ow') and file.lower().endswith('.py'): | ||
| module_name = top_module_name + '.' + os.path.join(root, file).replace(os.path.sep, '.')[:-len('.py')] | ||
| module_name = top_module_name + '.'\ |
There was a problem hiding this comment.
I would rather have a too long line that a line that was split in a weird way just to make lint happy.
If I had to split this line, I would go with either
module_name = "{}.{}".format(
top_module_name,
os.path.join(root, file).replace(os.path.sep, '.')[:-len('.py')])
or
file, _ = os.path.splitext(file)
module_name = os.path.join(root, file).replace(os.path.sep, ".")
module_name = "{}.{}".format(top_module_name, module_name)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
2 tests fail:
test_report_widgets_evaluatetest_save_reportDescription of changes
Includes