Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] DomainEditor: Add horizontal header #2579

Merged
merged 1 commit into from
Sep 13, 2017

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Sep 12, 2017

Issue

DomainEditor (e.g. in the File Widget) does not have horizontal header and hence doesn't allow the user to resize the columns. This is a problem when the features have longer names.

Description of changes

I added the header. While it is better in terms of functionality, the previous design may have been less cluttered. @BlazZupan, what do you think?

screen shot 2017-09-11 at 21 57 27

Includes
  • Code changes

@codecov-io
Copy link

Codecov Report

Merging #2579 into master will increase coverage by <.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #2579      +/-   ##
==========================================
+ Coverage   75.02%   75.03%   +<.01%     
==========================================
  Files         327      327              
  Lines       57641    57646       +5     
==========================================
+ Hits        43248    43252       +4     
- Misses      14393    14394       +1

@ajdapretnar
Copy link
Contributor

Oh yes, I hated this, too!

@janezd
Copy link
Contributor Author

janezd commented Sep 13, 2017

Codecov/patch failed since tests don't seem to go into return Qt.AlignLeft (although the view in fact uses it) in

if role == Qt.TextAlignmentRole:
    return Qt.AlignLeft

I can obviously write a test that covers this line, but ... won't since there's nothing to test here.

@janezd janezd changed the title [RFC] DomainEditor: Add horizontal header [ENH] DomainEditor: Add horizontal header Sep 13, 2017
@BlazZupan BlazZupan merged commit ca9292e into biolab:master Sep 13, 2017
@ajdapretnar
Copy link
Contributor

This caused other problems. Now, it is impossible to resize the widget, even when all data are continuous (Values field is empty). Could you give it a look?

screen shot 2017-09-13 at 13 41 24

@janezd
Copy link
Contributor Author

janezd commented Sep 13, 2017

I can't replicate this -- I can resize it.

@ajdapretnar
Copy link
Contributor

Updated the master and now I can, too. Sorry for the panic. :O

@janezd janezd deleted the domain-editor-horizontal-header branch April 5, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants