Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] setup: Increase required setuptools version #2602

Merged
merged 1 commit into from
Sep 20, 2017

Conversation

ales-erjavec
Copy link
Contributor

Issue

Fixes gh-2600

Description of changes

Increase required setuptools version to 36.3

This is required for installing namespace packages from wheels
build with newer versions of setuptools (see setuptools issue 885)

Includes
  • Code changes
  • Tests
  • Documentation

This is required for installing namespace packages from wheels
build with newer versions of setuptools (see setuptools issue 885)

Fixes biolabgh-2600
@codecov-io
Copy link

codecov-io commented Sep 20, 2017

Codecov Report

Merging #2602 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2602   +/-   ##
=======================================
  Coverage   75.09%   75.09%           
=======================================
  Files         329      329           
  Lines       57773    57773           
=======================================
  Hits        43386    43386           
  Misses      14387    14387

@astaric astaric merged commit 8df4187 into biolab:master Sep 20, 2017
@astaric
Copy link
Member

astaric commented Sep 23, 2017

@ales-erjavec Do we also need to update the conda-spec file?
https://github.com/biolab/orange3/blob/master/scripts/windows/specs/conda-spec.txt

@ales-erjavec
Copy link
Contributor Author

It would be better to update conda-recipe/meta.yaml as well as the conda-forge one.

The conda-spec.txt is (an example of) a generated file. The env spec is otherwise rebuild when the installers get created.

@astaric
Copy link
Member

astaric commented Sep 24, 2017

Ok. I'll update the conda-forge recipe when we do the 3.6 release (probably this friday).

@ales-erjavec ales-erjavec deleted the macos-application-setuptools branch November 14, 2017 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants