Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] preprocess.randomization: Do not use the same seed for X, Y, and meta #2603

Merged
merged 2 commits into from
Sep 21, 2017

Conversation

ales-erjavec
Copy link
Contributor

Issue
  • File (iris) ->
  • Select Columns (select 'Petal width' as the only feature) ->
  • Randomize (Select both 'Classes' and 'Features', 'Replaceable shuffling') ->
  • Test & Score; Achieves 0.95 AUC with logistic regression.
Description of changes

Use the initial supplied seed to issue a separate seeds for X,Y,meta parts.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Sep 20, 2017

Codecov Report

Merging #2603 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2603      +/-   ##
==========================================
+ Coverage   75.09%   75.09%   +<.01%     
==========================================
  Files         329      329              
  Lines       57773    57778       +5     
==========================================
+ Hits        43386    43391       +5     
  Misses      14387    14387

@janezd janezd merged commit 351b364 into biolab:master Sep 21, 2017
@ales-erjavec ales-erjavec deleted the fixes/randomization-seed-reuse branch November 14, 2017 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants