[FIX] OWBaseLearner: Save learner name in workflow #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astaric
force-pushed
the
save-learner-name
branch
from
984e7ea
to
f585731
Compare
Codecov Report
@@ Coverage Diff @@
## master #2608 +/- ##
==========================================
+ Coverage 74.97% 74.98% +<.01%
==========================================
Files 331 331
Lines 58041 58053 +12
==========================================
+ Hits 43519 43532 +13
+ Misses 14522 14521 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Learner names are not saved in workflows (Fixes #2601)
Description of changes
Declare learner_name as a schema_only setting. Fill default value in init when not loading from workflow.
Includes