Feature Constructor: Add some builtin functions #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2611 +/- ##
==========================================
+ Coverage 74.99% 74.99% +<.01%
==========================================
Files 331 331
Lines 58076 58081 +5
==========================================
+ Hits 43555 43560 +5
Misses 14521 14521 |
jerneju
approved these changes
Sep 22, 2017
|
Could you also provide some tests? |
janezd
force-pushed
the
feature-constructor-builtins
branch
from
ebf5381
to
4f63c27
Compare
|
I was like -- test what? Then I tested whether Fixed and done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Feature Constructor widget does not offer
absin the combo.Description of changes
I added
absand, while at it, also some other builtin function that could be useful.Includes