-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] settings: Do not clear schema_only settings on close_context #2691
[FIX] settings: Do not clear schema_only settings on close_context #2691
Conversation
3057ff6
to
cbefe1b
Compare
Codecov Report
@@ Coverage Diff @@
## master #2691 +/- ##
==========================================
+ Coverage 75.83% 75.83% +<.01%
==========================================
Files 338 338
Lines 59545 59566 +21
==========================================
+ Hits 45156 45173 +17
- Misses 14389 14393 +4 |
What if not only scatter plot; would all widgets need a |
Presumably, yes. |
cbefe1b
to
c4e8017
Compare
A kingdom for a saveState slot. |
@ales-erjavec the addition of sparse support in scatter plot created conflicts with this. Can you rebase? |
* undo changes to settings from biolabgh-2301 * change selection restore in scatter plot and linear projection accordingly
4bba9ce
to
8767e6e
Compare
Ok. |
Thanks |
Issue
Since gh-2301 schema_only settings are destructively cleared when used in combination with a context handler. This breaks (what I would hope to be) a valid use case
This state where bar is None would then be saved in a workflow.
This pattern is used in Textable add-on for issuing uuids to widgets
The same pattern is also used in OWBaseLearner widget for the learner_name but without a context handler.
I am not sure what the intent there was. Presumably the semantics of the selection restore in scatter plot, ... is such that it is only applied once when restored from a saved workflow.
Description of changes
Includes