[FIX] Correspondence Analysis: do not crash when no categorical #2723
Conversation
categorical variables
Codecov Report
@@ Coverage Diff @@
## master #2723 +/- ##
==========================================
+ Coverage 76.03% 76.04% +<.01%
==========================================
Files 338 338
Lines 59628 59643 +15
==========================================
+ Hits 45339 45356 +17
+ Misses 14289 14287 -2 |
| @@ -61,6 +61,7 @@ class Inputs: | |||
|
|
|||
| class Error(widget.OWWidget.Error): | |||
| empty_data = widget.Msg("Empty data set") | |||
| no_disc_vars = widget.Msg("Correspondence Analysis needs categorical variables") | |||
There was a problem hiding this comment.
Add a period at the end (we follow the rule that if the message is a complete sentence, we add a period).
Alternatively, shorten this to "No categorical variables" (without a period).
| self._restore_selection() | ||
| # self._invalidate() | ||
| if not len(self.varlist[:]): | ||
| self.Error.no_disc_vars() |
There was a problem hiding this comment.
Add self.data = None here. Not needed right now, but the above code sets it to None as the indicator that no data is shown.
| self.send_signal(self.widget.Inputs.data, table) | ||
| self.assertTrue(self.widget.Error.no_disc_vars.is_shown()) | ||
| self.send_signal(self.widget.Inputs.data, None) | ||
| self.assertFalse(self.widget.Error.no_disc_vars.is_shown()) |
There was a problem hiding this comment.
Add
self.send_signal(self.widget.Inputs.data, table)
self.assertTrue(self.widget.Error.no_disc_vars.is_shown())
self.send_signal(self.widget.Inputs.data, Table("iris"))
self.assertFalse(self.widget.Error.no_disc_vars.is_shown())
We have had bugs in the past where the error message was sometimes not cleared.
| @@ -102,6 +103,7 @@ def __init__(self): | |||
| def set_data(self, data): | |||
| self.closeContext() | |||
| self.clear() | |||
| self.Error.no_disc_vars.clear() | |||
There was a problem hiding this comment.
Since the widget is reset here, I suppose that no error should remain visible from the previous data. So you can safely call self.Error.clear() instead of self.Error.no_disc_vars.clear(), and then you can also remove else: self.Error.empty_data.clear() below.
|
Actually, I can take care of my nitpicking myself. :) |
Issue
Widget crashes when there are no categorical variables in a data.
Description of changes
Check and show error.
Includes