[FIX] Scatter Plot: VizRank disabled when no class vars #2757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2757 +/- ##
==========================================
+ Coverage 76.05% 76.06% +<.01%
==========================================
Files 338 338
Lines 59670 59683 +13
==========================================
+ Hits 45380 45395 +15
+ Misses 14290 14288 -2 |
lanzagar
reviewed
Nov 10, 2017
| domain = Domain( | ||
| attributes=data2.domain.attributes[:4], class_vars=DiscreteVariable("iris", values=[])) | ||
| data2 = Table(domain, data2.X, Y=data2.Y) | ||
| data3 = Table("iris")[::30] |
There was a problem hiding this comment.
What is the difference between data1 and data3? (i.e. why this line)
There was a problem hiding this comment.
Now there is the difference.
lanzagar
requested changes
Nov 10, 2017
| @@ -252,6 +252,8 @@ def set_data(self, data): | |||
| self.vizrank_button.setEnabled( | |||
| self.data is not None and not self.data.is_sparse() and | |||
| self.data.domain.class_var is not None and | |||
| (len(self.data.domain.class_var.values) | |||
| if self.data.domain.class_var.is_discrete else True) and | |||
There was a problem hiding this comment.
This fixes the case when the class has no values. How about when the class has e.g. 3 values, but all instances have unknown classes (e.g. a test set with the same variable as the training set, but class unknown)
There was a problem hiding this comment.
Good point! Updated.
lanzagar
approved these changes
Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Scatter Plot VizRank crashes when class column has only
nanvalues.Description of changes
VizRank is disabled as it is when there is no
class_var.Includes