[FIX] Canvas: Palette propagation #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ales-erjavec
force-pushed
the
canvas/palette-propagation
branch
from
168d2d0
to
ef803ac
Compare
Codecov Report
@@ Coverage Diff @@
## master #2760 +/- ##
=======================================
Coverage 81.67% 81.67%
=======================================
Files 323 323
Lines 55420 55420
=======================================
Hits 45264 45264
Misses 10156 10156 |
|
❤️ Any possibility to also support |
|
What do you mean? QT_STYLE_OVERRIDE works the same as always. |
|
Hmm, I set $ env | grep QT_STYLE
QT_STYLE_OVERRIDE=adwaita-darkI guess it's got to do with paths and the virtualenv I have PyQt5 in. |
|
Do you have PyQt5 installed from wheels? Try using the system provided PyQt5. I.e. use |
ales-erjavec
force-pushed
the
canvas/palette-propagation
branch
2 times, most recently
from
751c275
to
bcb07f6
Compare
|
That did the trick. Looks quite good. Except the icons, perhaps, aren't best suited to dark themes.
|
Use QGraphicsWidget's propagated font and palette for text styling.
Can now pass --style=fusion or --style=fusion:breeze-dark. Also suppress the default orange style when the application global palette is too dark.
ales-erjavec
force-pushed
the
canvas/palette-propagation
branch
from
bcb07f6
to
d2267dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Canvas conflicts with dark theme/styles, e.g:
Description of changes
If deemed necessary a GUI option in the preferences dialog can also be added to select the style.Includes