[FIX] Nomogram on PyQt4 #2763
Merged
[FIX] Nomogram on PyQt4 #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to add () to make Nomograms work on Qt4: avail = QDesktopWidget().availableGeometry(self) |
Codecov Report
@@ Coverage Diff @@
## master #2763 +/- ##
==========================================
+ Coverage 76.06% 76.07% +<.01%
==========================================
Files 338 338
Lines 59699 59703 +4
==========================================
+ Hits 45413 45421 +8
+ Misses 14286 14282 -4 |
markotoplak
approved these changes
Nov 10, 2017
There was a problem hiding this comment.
Naive Bayes and data set selection saving work for me.
It would be nice to have these in separate PR. Please also separate row height. Also, someone should test row height on retina (@astaric , could you?)
| @@ -50,7 +51,7 @@ def show(self, pos, text, change_y=True): | |||
| self.adjustSize() | |||
|
|
|||
| x, y = pos.x(), (pos.y() + 15 if change_y else self.y()) | |||
| avail = QApplication.focusWindow().screen().availableGeometry() | |||
| avail = QDesktopWidget.availableGeometry(self) | |||
There was a problem hiding this comment.
avail = QDesktopWidget().availableGeometry(self)
Neither. If you insist, feel free to adjust it as you will. |
|
Colud we have a test that (at least) runs this code on? |
nikicc
pushed a commit
to nikicc/orange3
that referenced
this pull request
Nov 17, 2017
[FIX] Nomogram on PyQt4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description of changes
Fixed.
Includes