Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Windows installers: Python lookup #2827

Merged
merged 6 commits into from
Dec 22, 2017

Conversation

ales-erjavec
Copy link
Contributor

Issue
Description of changes
  • Validate conda install layout
  • Fix registry key lookup for 32 bit python >= 3.5
Includes
  • Code changes
  • Tests
  • Documentation

To find 32 bit python >= 3.5 it is necessary to add explicit -32 suffix
to the tag name (sys.winver - PEP 514)
@lanzagar lanzagar added this to the 3.9 milestone Dec 18, 2017
Add a start menu shortcut for droping into the activated env.
Allow the nsis installer to save the selected folder name in the
registry
@codecov-io
Copy link

codecov-io commented Dec 19, 2017

Codecov Report

Merging #2827 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2827      +/-   ##
==========================================
+ Coverage   81.95%   81.96%   +0.01%     
==========================================
  Files         321      321              
  Lines       54823    54841      +18     
==========================================
+ Hits        44928    44952      +24     
+ Misses       9895     9889       -6

@astaric
Copy link
Member

astaric commented Dec 20, 2017

Is there a way to specify the order of entries in the start menu? Currently Orange Command Prompt comes before Orange. (miniconda installer)

@ales-erjavec
Copy link
Contributor Author

Orange comes first for me:
screen shot 2017-12-20 at 10 08 35

@astaric
Copy link
Member

astaric commented Dec 20, 2017

I was testing it on windows 7, I guess windows changed the default ordering since then. If Orange is listed first on recent versions of windows, it is ok

screen shot 2017-12-20 at 10 39 35

@astaric
Copy link
Member

astaric commented Dec 22, 2017

I have tested the miniconda stuff and it works. Not sure how to reproduce the regular installer problem though.

@ales-erjavec
Copy link
Contributor Author

ales-erjavec commented Dec 22, 2017

Not sure how to reproduce the regular installer problem though.

The 32-bit regular installers for Python >= 3.5 did not work at all. They would fail with "Python installation failed (cannot determine Python installation prefix)" or with a pip error "...win32.whl is not a supported wheel on this platform" depending on whether 64 bit Python was already installed.

To reproduce the error create a installer on master

./scripts/windows/build-win-installer.sh --python-version 3.6.3 --platform win32 --pip-arg={orange3==3.8.0,PyQt5,-f,https://orange.biolab.si/download/files/wheelhouse}

and try running it.

@astaric
Copy link
Member

astaric commented Dec 22, 2017

Thanks. As the new installers work (for me) I am merging this.

@astaric astaric merged commit 84a75ad into biolab:master Dec 22, 2017
@ales-erjavec ales-erjavec deleted the fixes/win-installer branch December 22, 2017 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants