Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] canvas/addons: Fix progress dialog showing up when not necessary #2833

Merged
merged 1 commit into from
Dec 20, 2017

Conversation

ales-erjavec
Copy link
Contributor

Issue

Go to Options -> Add-ons, wait until it updates the packages list then close the dialog. Open Options -> Add-ons again. The dialog is populated immediately, but wait ~4 sec. A progress dialog shows up and does not go away until cancelled.

Description of changes

Create the dialog only when starting a task.

Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec changed the title canvas/addons: Fix progress dialog showing up when not necessary [FIX] canvas/addons: Fix progress dialog showing up when not necessary Dec 18, 2017
@lanzagar lanzagar added this to the 3.9 milestone Dec 18, 2017
Copy link
Member

@astaric astaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described

self.__thread = None
self.__installer = None

if not self._f_pypi_addons.done():
p = self.__progressDialog()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This p is not used anywhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Create the dialog only when starting a task.
@ales-erjavec ales-erjavec force-pushed the fixes/addons-progress-dialog branch from e2a5bd6 to d9f60a1 Compare December 20, 2017 08:33
@codecov-io
Copy link

Codecov Report

Merging #2833 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2833   +/-   ##
=======================================
  Coverage   81.96%   81.96%           
=======================================
  Files         321      321           
  Lines       54841    54841           
=======================================
  Hits        44952    44952           
  Misses       9889     9889

@astaric astaric merged commit 62ce683 into biolab:master Dec 20, 2017
@ales-erjavec ales-erjavec deleted the fixes/addons-progress-dialog branch December 20, 2017 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants