[FIX] utils/concurrent: Handle an empty futures list #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, ensure a `doneAll` signal is always emitted
ales-erjavec
force-pushed
the
fixes/future-set-watcher-empty
branch
from
28ea359
to
73cc7ad
Compare
ales-erjavec
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2834 +/- ##
==========================================
+ Coverage 81.72% 81.74% +0.02%
==========================================
Files 326 326
Lines 55700 55736 +36
==========================================
+ Hits 45521 45562 +41
+ Misses 10179 10174 -5 |
ales-erjavec
changed the title
Explicitly track done callback invocations.
ales-erjavec
force-pushed
the
fixes/future-set-watcher-empty
branch
from
5681d0f
to
0c0ecc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
It is possible that a client passes a empty futures list to
FutureSetWatcher. In this case thedoneAllsignal is not emitted which might cause the client to never resume progress it it does not handle the empty futures list.Description of changes
Ensure a
doneAllsignal is emitted even for an empty futures list.Includes