Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] utils/concurrent: Handle an empty futures list #2834

Merged
merged 2 commits into from
Jan 18, 2018

Conversation

ales-erjavec
Copy link
Contributor

Issue

It is possible that a client passes a empty futures list to FutureSetWatcher. In this case the doneAll signal is not emitted which might cause the client to never resume progress it it does not handle the empty futures list.

Description of changes

Ensure a doneAll signal is emitted even for an empty futures list.

Includes
  • Code changes
  • Tests
  • Documentation

That is, ensure a `doneAll` signal is always emitted
@ales-erjavec ales-erjavec force-pushed the fixes/future-set-watcher-empty branch from 28ea359 to 73cc7ad Compare December 18, 2017 09:57
@lanzagar lanzagar added this to the 3.9 milestone Dec 18, 2017
@ales-erjavec ales-erjavec changed the title [FIX] utils/concurrent: Handle an empty futures list [WIP][FIX] utils/concurrent: Handle an empty futures list Dec 21, 2017
@codecov-io
Copy link

codecov-io commented Dec 21, 2017

Codecov Report

Merging #2834 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2834      +/-   ##
==========================================
+ Coverage   81.72%   81.74%   +0.02%     
==========================================
  Files         326      326              
  Lines       55700    55736      +36     
==========================================
+ Hits        45521    45562      +41     
+ Misses      10179    10174       -5

@ales-erjavec ales-erjavec changed the title [WIP][FIX] utils/concurrent: Handle an empty futures list [FIX] utils/concurrent: Handle an empty futures list Dec 21, 2017
Explicitly track done callback invocations.
@ales-erjavec ales-erjavec force-pushed the fixes/future-set-watcher-empty branch from 5681d0f to 0c0ecc9 Compare December 22, 2017 14:05
@lanzagar lanzagar merged commit a6aafd6 into biolab:master Jan 18, 2018
@ales-erjavec ales-erjavec deleted the fixes/future-set-watcher-empty branch January 26, 2018 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants