Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] distribution.py: Fix computation on multiclass data #2903

Merged
merged 10 commits into from
Feb 26, 2018

Conversation

pavlin-policar
Copy link
Collaborator

#2680, but without 7d675ba. Apparently force-pushing on a closed PR makes it impossible to re-open it, hence the new PR... @kernc could you take a look?

Issue

The function class_distribution was apparently never used throughout the entire codebase and was never tested, and the parameter ordering was incorrect.

Description of changes

af5a1c7 fixes the mentioned issue. The other commits add various tests, docstrings and code formatting fixes. I've also added a better sample method, similar to the python random.sample. I've also added min and max for ordered categorical variables.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

Codecov Report

Merging #2903 into master will decrease coverage by <.01%.
The diff coverage is 75.36%.

@@            Coverage Diff             @@
##           master    #2903      +/-   ##
==========================================
- Coverage   82.15%   82.14%   -0.01%     
==========================================
  Files         329      329              
  Lines       56290    56290              
==========================================
- Hits        46244    46240       -4     
- Misses      10046    10050       +4

@lanzagar lanzagar changed the title [FIX] Update distributions [FIX] distribution.py: Fix computation on multiclass data Feb 26, 2018
@lanzagar lanzagar merged commit 3fdba8d into biolab:master Feb 26, 2018
@lanzagar lanzagar added this to the 3.11 milestone Feb 26, 2018
@pavlin-policar pavlin-policar deleted the update-distributions branch February 26, 2018 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants