[FIX] distribution.py: Fix computation on multiclass data #2903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2680, but without 7d675ba. Apparently force-pushing on a closed PR makes it impossible to re-open it, hence the new PR... @kernc could you take a look?
Issue
The function
class_distribution
was apparently never used throughout the entire codebase and was never tested, and the parameter ordering was incorrect.Description of changes
af5a1c7 fixes the mentioned issue. The other commits add various tests, docstrings and code formatting fixes. I've also added a better
sample
method, similar to the pythonrandom.sample
. I've also addedmin
andmax
for ordered categorical variables.Includes