[FIX] Test and Score: Fix averaging over classes for binary scores #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2918 +/- ##
==========================================
+ Coverage 82.1% 82.12% +0.01%
==========================================
Files 328 328
Lines 56262 56283 +21
==========================================
+ Hits 46194 46221 +27
+ Misses 10068 10062 -6 |
PrimozGodec
force-pushed
the
auc-fix
branch
8 times, most recently
from
cd22d61
to
e71392f
Compare
lanzagar
reviewed
Feb 23, 2018
| virginica_auc = float(w.view.model().item(0, 1).text()) | ||
|
|
||
| self.assertIsNotNone(average_auc) | ||
| self.assertIsNotNone(versicolor_auc) |
There was a problem hiding this comment.
Why is checking that the aucs are not None necessary?
If they would not be computed, the conversion to float would fail before this anyway.
…o target selected
lanzagar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Binary scores were evaluated with target class when no target class was selected
Description of changes
This PR is fixing binary scores to use weighted scoring when no target class is selected
Includes