Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Sieve Diagram: Fix spacing of axis labels #2971

Merged
merged 1 commit into from
Apr 5, 2018

Conversation

awgnuhcam
Copy link

Issue

The longer the horizontal label, the more white space between the vertical label and the sieve rectangle. Try it on any data with long attribute names.

Description of changes

See the code.

Includes
  • Code changes
  • Tests
  • Documentation

@CLAassistant
Copy link

CLAassistant commented Mar 23, 2018

CLA assistant check
All committers have signed the CLA.

@lanzagar lanzagar added this to the 3.12 milestone Mar 30, 2018
@lanzagar
Copy link
Contributor

Thank you for spotting the problem and fixing it!

Can you sign the CLA please so we can merge your change. The commit is not linked to a github account yet, so you should probably follow the instructions in the second part of the CLA comment.

@codecov-io
Copy link

Codecov Report

Merging #2971 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2971      +/-   ##
==========================================
+ Coverage   81.85%   81.87%   +0.01%     
==========================================
  Files         329      329              
  Lines       56781    56830      +49     
==========================================
+ Hits        46480    46527      +47     
- Misses      10301    10303       +2

@lanzagar lanzagar changed the title Fix positioning of Sieve diagram [FIX] Sieve Diagram: Fix spacing of axis labels Mar 30, 2018
@awgnuhcam
Copy link
Author

CLA seems reasonable for an organization. For an outside contributor, not so much. I commit the code to get better software. I sign CLA to get - what? There's nothing in it for me. CLA takes the code from contributors to organizations and pushes responsibility for the code from organizations to contributors.

On top of that, it's just two lines of code, which almost duplicate the existing code, and an obvious fix in the third line. It's not something to get sued for, is it?

I signed anyway. I know you have a procedure to follow and three lines are not worth complicating our lives. This message is already way longer (and took me more time) than the code. It's just interesting to think about this from another perspective. :)

@kernc
Copy link
Contributor

kernc commented Apr 5, 2018

Contributing on GitHub, you already agreed to have your changes incorporated under each respective project's license. The CLA further amends the project's license with provisions that allow UL FRI, Biolab, the current project steward, to dual-license or relicense the software at its discretion, basically giving it a bit more legal freedom than the rest of the community has (§2.1, §3.2). That and certain warranties from you (§5).

I sign CLA to get - what?

The community gets better software offered under GNU GPL.

Indeed, it's blackmail.

@kernc kernc merged commit c9f5865 into biolab:master Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants