Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] test: Fix tests for 'Datasets' widget #3033

Merged
merged 1 commit into from
May 16, 2018

Conversation

ales-erjavec
Copy link
Contributor

Issue

Tests for Datasets widget fail at random as they do not account for its asynchronous nature

Description of changes

Wait until the initialization completes.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

Codecov Report

Merging #3033 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3033      +/-   ##
==========================================
+ Coverage   82.27%   82.27%   +<.01%     
==========================================
  Files         335      335              
  Lines       57755    57760       +5     
==========================================
+ Hits        47519    47524       +5     
  Misses      10236    10236

@lanzagar lanzagar merged commit fd479b0 into biolab:master May 16, 2018
@ales-erjavec ales-erjavec deleted the fixes/test_owdatasets branch May 16, 2018 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants