Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Canvas: Fix 'Widgest on top' #3068

Merged
merged 4 commits into from
Jun 15, 2018

Conversation

ales-erjavec
Copy link
Contributor

Issue

On some platforms (Windows, Gnome) setting window flags and/or hide/show implicitly triggers
application deactivate/reactivate, triggering an endless back and forth
state changes. This can outright seemingly freeze desktop shell.

Description of changes

Remove window flags modification on application state change.

Includes
  • Code changes
  • Tests
  • Documentation

On some platforms setting window flags and/or hide/show implicitly triggers
application deactivate/reactivate, triggering an endless back and forth
state changes.
@ales-erjavec ales-erjavec force-pushed the fixes/always-on-top branch from f529f93 to d4cdf78 Compare June 15, 2018 07:10
@codecov-io
Copy link

codecov-io commented Jun 15, 2018

Codecov Report

Merging #3068 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3068      +/-   ##
==========================================
+ Coverage   82.38%   82.38%   +<.01%     
==========================================
  Files         335      335              
  Lines       57990    57990              
==========================================
+ Hits        47775    47776       +1     
+ Misses      10215    10214       -1

@astaric astaric merged commit bbf355d into biolab:master Jun 15, 2018
@ales-erjavec ales-erjavec deleted the fixes/always-on-top branch September 12, 2018 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants