Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] OWWidget: Collapse/expand the widget on control area toggle #3146

Merged
merged 2 commits into from
Jul 31, 2018

Conversation

ales-erjavec
Copy link
Contributor

Issue

Implements gh-3144

Description of changes

Collapse/expand the widget on control area toggle by the control area width

Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec force-pushed the control-area-shrink branch from 97a007c to 62760bc Compare July 20, 2018 14:42
@codecov-io
Copy link

codecov-io commented Jul 20, 2018

Codecov Report

Merging #3146 into master will increase coverage by <.01%.
The diff coverage is 84.44%.

@@            Coverage Diff             @@
##           master    #3146      +/-   ##
==========================================
+ Coverage   82.35%   82.35%   +<.01%     
==========================================
  Files         335      335              
  Lines       58256    58277      +21     
==========================================
+ Hits        47977    47995      +18     
- Misses      10279    10282       +3

@ajdapretnar
Copy link
Contributor

I made a mess. I didn't realize merging #3141 also touches widget.py. Should I revert and keep this one instead?

@ales-erjavec
Copy link
Contributor Author

No. I can rebase.

@ales-erjavec ales-erjavec force-pushed the control-area-shrink branch from 62760bc to 8606eea Compare July 24, 2018 09:59
@thocevar thocevar self-requested a review July 24, 2018 11:32
@thocevar
Copy link
Contributor

There is a visible blink/movement of items in the main area when the widget moves and then shrinks. Is it perhaps possible to do this in a single update?

@ales-erjavec
Copy link
Contributor Author

ales-erjavec commented Jul 24, 2018

Is it perhaps possible to do this in a single update?

Probably not. This seems platform dependent.

On Gnome, KDE, ... fast repeat causes the widget to 'travel' to the
right.
@ajdapretnar
Copy link
Contributor

I like this. I don't experience any blinking on OSX (but this is after the last commit). There is an occasional update of the plot (or at least it looks like the graph is replotted), but it doesn't bother. Not sure what would happen on bigger data set, but perhaps it is not replotting but just a small glitch. :)

@lanzagar lanzagar merged commit d7e3e09 into biolab:master Jul 31, 2018
@ales-erjavec ales-erjavec deleted the control-area-shrink branch September 12, 2018 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants