[FIX] WebView fixes #3148
Merged
[FIX] WebView fixes #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
astaric
reviewed
Jul 23, 2018
Orange/widgets/utils/webview.py
Outdated
| with self.lock: | ||
| self.ids.add(id) | ||
| self.ids[id] = value | ||
|
|
||
| def __contains__(self, id): | ||
| return id in self.ids | ||
|
|
||
| def remove(self, id): |
There was a problem hiding this comment.
Maybe this could be renamed to pop?
Codecov Report
@@ Coverage Diff @@
## master #3148 +/- ##
=========================================
Coverage ? 82.35%
=========================================
Files ? 335
Lines ? 58256
Branches ? 0
=========================================
Hits ? 47977
Misses ? 10279
Partials ? 0 |
astaric
approved these changes
Jul 23, 2018
Orange/widgets/utils/webview.py
Outdated
| @@ -556,9 +556,9 @@ def _evalJS(self, code): | |||
| if sip.isdeleted(self): | |||
| return | |||
There was a problem hiding this comment.
Lint suggests that you return None here.
(Either all return statements in a function should return an expression, or none of them should.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description of changes
<svg>tag results in ValueError (and not IndexError).Includes