-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] OWBoxPlot: add option to sort discrete distributions by size #3156
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3156 +/- ##
==========================================
+ Coverage 82.36% 82.63% +0.27%
==========================================
Files 336 342 +6
Lines 58289 58995 +706
==========================================
+ Hits 48011 48752 +741
+ Misses 10278 10243 -35 |
Looks good, but sometimes while toggling the sorting the figure is not redrawn properly. |
Should be fixed now (i. e. I could not reproduce the issue anymore after d9fc998). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected.
I would change the test dataset to something smaller though.
@@ -176,6 +176,20 @@ def test_empty_groups(self): | |||
self.send_signal(self.widget.Inputs.data, table) | |||
self.assertEqual(2, len(self.widget.boxes)) | |||
|
|||
def test_sorting_disc_group_var(self): | |||
"""Test if subgroups are sorted by their size""" | |||
table = Table("adult") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you use adult_sample? loading adult takes 0.5s to load on my computer, while loading adult_samples is instant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, there really was no reason to use such a large dataset for testing this.
…ple instead of adult
Thanks |
Issue
Implements #3093.
Description of changes
Added option (checkbox) to allow sorting discrete distributions by their size. If checkbox is unchecked, original order is preserved.
Includes