Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] OWBoxPlot: Fix quartiles computation #3159

Merged
merged 1 commit into from
Jul 30, 2018

Conversation

ales-erjavec
Copy link
Contributor

Issue

Ref gh-1737

Fix quartiles computation

The code assumed that all quartiles would (or need to) be distinct.

Description of changes

Replace the linear scan in BoxPlot constructor with a numpy based implementation.

Includes
  • Code changes
  • Tests
  • Documentation

The code assumed that all quartiles would (or need to) be distinct.

Replace the linear scan with a numpy implementation.
@ales-erjavec ales-erjavec force-pushed the fixes/box-plot-quantiles branch from c5eb7fc to b94b892 Compare July 26, 2018 13:32
@codecov-io
Copy link

codecov-io commented Jul 26, 2018

Codecov Report

Merging #3159 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3159      +/-   ##
==========================================
+ Coverage   82.37%   82.37%   +<.01%     
==========================================
  Files         336      336              
  Lines       58303    58320      +17     
==========================================
+ Hits        48025    48041      +16     
- Misses      10278    10279       +1

@ajdapretnar ajdapretnar merged commit 2e04b0c into biolab:master Jul 30, 2018
@ales-erjavec ales-erjavec deleted the fixes/box-plot-quantiles branch September 12, 2018 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants