Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] RemoveConstant: remove constant NaN features. #3163

Merged
merged 1 commit into from
Jul 31, 2018

Conversation

thocevar
Copy link
Contributor

Issue

RemoveConstant doesn't remove columns containing only NaN values.

Description of changes

Comparison of min and max value in a column doesn't work for features containing only nan-s (because np.nan != np.nan). Check for this separately.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

Codecov Report

Merging #3163 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3163   +/-   ##
=======================================
  Coverage   82.37%   82.37%           
=======================================
  Files         336      336           
  Lines       58303    58303           
=======================================
  Hits        48025    48025           
  Misses      10278    10278

@thocevar thocevar changed the title RemoveConstant: remove constant NaN features. [FIX] RemoveConstant: remove constant NaN features. Jul 30, 2018
@lanzagar lanzagar merged commit 7504b9d into biolab:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants