[FIX] OWBoxPlot: Fix empty continuous contingency check #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contingencies for continuous variables are (2, N) shaped where the only the second row contains the counts.
lanzagar
reviewed
Aug 3, 2018
| @@ -158,9 +158,9 @@ def test_label_overlap(self): | |||
| self.widget.stretched = False | |||
| self.__select_variable("chest pain") | |||
| self.__select_group("gender") | |||
| self.widget.show() | |||
| QTest.qWait(3000) | |||
There was a problem hiding this comment.
You removed the only use of QTest. Can you remove the import too, so pylint does not complain about it being unused?
ales-erjavec
force-pushed
the
fixes/box-plot-empty-contingency-check
branch
from
26d630c
to
9763f6d
Compare
Codecov Report
@@ Coverage Diff @@
## master #3165 +/- ##
==========================================
+ Coverage 82.63% 82.63% +<.01%
==========================================
Files 340 340
Lines 58788 58796 +8
==========================================
+ Hits 48577 48585 +8
Misses 10211 10211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
A wrong check for empty continuous contingencies omits groups that it should not.
For instance on: vowel.tab.txt
on variable: f0, group by: Class
Description of changes
Fix check for empty continuous contingency, add asserts where contingencies are summed over.
Includes