[ENH] Table: speed-up computation of basic stats of given columns. #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thocevar
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3166 +/- ##
==========================================
+ Coverage 82.37% 82.37% +<.01%
==========================================
Files 336 336
Lines 58321 58319 -2
==========================================
Hits 48042 48042
+ Misses 10279 10277 -2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Imputation of tables with a large number of features is slow/unfeasible (e.g. #3129).
Imputation is done column by column, each time computing the basic stats. However, each time these stats are computed for the entire table (all columns) resulting in a quadratic time complexity.
Description of changes
Table's
_compute_basic_statshas acolumnsparameter. Before, it passed the entire table tostatistics.utils.statsand filtered the results. Now, we filter the table by given columns before passing it on for stats computation.Includes