Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] OWSelectByDataIndex: New widget (move from Prototypes) #3181

Merged
merged 4 commits into from
Aug 3, 2018

Conversation

ajdapretnar
Copy link
Contributor

Issue

Select by Data Index widget from Prototypes ready to be moved to core.

Description of changes

Move widget.

Includes
  • Code changes
  • Tests
  • Documentation


Now we will select an interesting subset (we could also select the entire data set). If we observe it in a **Data Table**, we can see that the data is transformed. If we would like to see this data with the original features, we will have to retrieve them with **Select by Data Index**.

Connect the original data and the subset from **Scatter Plot** to **Select by Data Index**. The widget will match the indices of the subset with the indices of the reference (original) data and put the matching reference data on the output. A final inspection in another **Data Table** confirms the data on the output is not from the original data space.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put the matching reference data on the output -> output the matching reference data
output is not from the original data space. -> IS from ...?

@lanzagar lanzagar changed the title OWSelectByDataIndex: move from Prototypes to core [ENH] OWSelectByDataIndex: New widget (move from Prototypes) Aug 2, 2018
@codecov-io
Copy link

Codecov Report

Merging #3181 into master will increase coverage by 0.01%.
The diff coverage is 89.01%.

@@            Coverage Diff             @@
##           master    #3181      +/-   ##
==========================================
+ Coverage   82.54%   82.55%   +0.01%     
==========================================
  Files         337      339       +2     
  Lines       58431    58522      +91     
==========================================
+ Hits        48229    48310      +81     
- Misses      10202    10212      +10

@lanzagar lanzagar added this to the 3.15 milestone Aug 3, 2018
@lanzagar lanzagar merged commit 3d97116 into biolab:master Aug 3, 2018
@ajdapretnar ajdapretnar deleted the select-by-data-index branch November 30, 2018 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants