[FIX] owlouvainclustering: Make the task completion handler a single slot #3182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The
Orange.widgets.unsupervised.tests.test_owlouvain.TestOWLouvain.test_clusters_ordered_by_size
test errors randomly with:Description of changes
Make the task completion handler a single slot.
The handlers are invoked with the Qt.QueuedConnection semantics and the first (_processing_complete) advertised to the world that the processing has completed, but the actual send would be done later at an unspecified time. This tripped the
TestOWLouvain.test_clusters_ordered_by_size
test.Includes