Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Data Info display data set name #3187

Merged
merged 8 commits into from
Nov 26, 2018
Merged

[ENH] Data Info display data set name #3187

merged 8 commits into from
Nov 26, 2018

Conversation

BlazZupan
Copy link
Contributor

Issue

No data set name displayed in the info box. This could be important when checking if the names of the data sets are set correctly.

Description of changes

Includes the box with the data set name.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Aug 5, 2018

Codecov Report

Merging #3187 into master will increase coverage by 0.06%.
The diff coverage is 77.08%.

@@            Coverage Diff             @@
##           master    #3187      +/-   ##
==========================================
+ Coverage   82.06%   82.13%   +0.06%     
==========================================
  Files         351      351              
  Lines       61898    62168     +270     
==========================================
+ Hits        50799    51061     +262     
- Misses      11099    11107       +8

Copy link
Contributor

@lanzagar lanzagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name should also be added to the report.

Also, I noticed this widget still uses "discrete" in several places. This should be changed to "categorical". Maybe it can be added to the same PR?

if hasattr(data, "name"):
self.data_set_name = data.name
else:
self.data_set_name = "N/A"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.data_set_name = getattr(data, "name", "N/A")

@janezd janezd force-pushed the datainfo-filename branch from 3512bad to 41c5f3b Compare October 23, 2018 21:52
@janezd janezd added this to the 3.19 milestone Nov 16, 2018
@thocevar thocevar self-assigned this Nov 23, 2018
@thocevar thocevar merged commit b27bf8b into master Nov 26, 2018
@lanzagar lanzagar deleted the datainfo-filename branch February 15, 2019 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants