Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] OWNeuralNetwork model pickling #3230

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

markotoplak
Copy link
Member

@markotoplak markotoplak commented Sep 5, 2018

Issue

Fixes #3223

Includes
  • Code changes
  • Tests
  • Documentation

@markotoplak markotoplak changed the title Fix OWNeuralNetwork model pickling [FIX] OWNeuralNetwork model pickling Sep 5, 2018
@enjoysmath
Copy link

How do / when can I use this fix?

@markotoplak
Copy link
Member Author

@enjoysmath, you could checkout the branch with the fixes, and then install and run it. Perhaps an easier option is to find owneuralnetwork.py on your computer and add that 1 line I added there in this PR (the rest are tests).

@enjoysmath
Copy link

enjoysmath commented Sep 5, 2018 via email

@astaric
Copy link
Member

astaric commented Sep 7, 2018

@markotoplak, can you rebase on to the latest master? The windows failure is unrelated to these changes, but I would like to see if the new test passes.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@9b1fdc3). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             master   #3230   +/-   ##
========================================
  Coverage          ?   82.8%           
========================================
  Files             ?     346           
  Lines             ?   59613           
  Branches          ?       0           
========================================
  Hits              ?   49364           
  Misses            ?   10249           
  Partials          ?       0

@lanzagar lanzagar added this to the 3.16 milestone Sep 12, 2018
@lanzagar lanzagar merged commit ac0e1c5 into biolab:master Sep 12, 2018
@markotoplak markotoplak deleted the fix-nn-pickle branch October 8, 2018 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants