[ENH] OWHierarchicalClustering: Use selection indices for selection restore #3282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ales-erjavec
force-pushed
the
fixes/hierarchical_selection
branch
from
97d355a
to
7a7f1bd
Compare
Codecov Report
@@ Coverage Diff @@
## master #3282 +/- ##
==========================================
+ Coverage 82.32% 82.34% +0.01%
==========================================
Files 360 360
Lines 64096 64193 +97
==========================================
+ Hits 52767 52857 +90
- Misses 11329 11336 +7 |
ales-erjavec
force-pushed
the
fixes/hierarchical_selection
branch
2 times, most recently
from
0df0f1a
to
cc2e253
Compare
|
Can you please rebase? |
Change selection serialization and add dendrogram structure validation on restore. I.e. only restore if the linkage matrix matches (small leeway for inexact FP math is allowed).
ales-erjavec
force-pushed
the
fixes/hierarchical_selection
branch
from
cc2e253
to
65973d2
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
References gh-1563
Applies on top of gh-3249
Description of changes
Includes