Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] setup.py: Remove trailing slash from directory names in data_files #3394

Merged
merged 3 commits into from
Nov 13, 2018
Merged

[FIX] setup.py: Remove trailing slash from directory names in data_files #3394

merged 3 commits into from
Nov 13, 2018

Conversation

ales-erjavec
Copy link
Contributor

Issue

Running python setup.py bdist_wheel with sphinx installed on windows results in:

...
ValueError: path 'share/help/en/orange3/htmlhelp/' cannot end with '/'
Description of changes
  • Avoid trailing slash in directory names in data_files
Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec
setup.py: Remove trailing slash from directory names in data_files
f4e41ca 
On windows distutils `install_data` rejects such names.
@ales-erjavec
ci/appveyor: Add sphinx to build environment
10aae31
@ales-erjavec
ci/appveyor: Remove MSVC 2010 workaround
f53b5e8 
No longer needed since Python 3.4 was removed form the test matrix
@lanzagar lanzagar added this to the 3.18 milestone Nov 13, 2018
@lanzagar lanzagar merged commit 746eb0d into biolab:master Nov 13, 2018
@ales-erjavec ales-erjavec deleted the fixes/setup-data-files branch May 20, 2019 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.18
Development

Successfully merging this pull request may close these issues.
2 participants
@ales-erjavec @lanzagar