Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]t-SNE: Generate temporary projection data #3454

Merged
merged 1 commit into from
Dec 8, 2018

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Dec 7, 2018

Issue

Fixes #3452

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

data = self.data.transform(
Domain(self.data.domain.attributes,
self.data.domain.class_vars,
self.data.domain.metas + self.projection.domain.attributes))
self.data.domain.metas + variables))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if I got this right, you're just adding the two t-SNE variables with empty values until the embedding is actually computed and populated with the actual embedding values. That seems all right.

Ideally, you wouldn't even need to draw anything until the embedding finishes, but I don't know how hard that may be to implement...

@pavlin-policar
Copy link
Collaborator

Fixes the issue. Will merge once as the tests pass.

@codecov
Copy link

codecov bot commented Dec 8, 2018

Codecov Report

Merging #3454 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3454      +/-   ##
==========================================
+ Coverage   83.26%   83.28%   +0.01%     
==========================================
  Files         365      365              
  Lines       64306    64316      +10     
==========================================
+ Hits        53547    53563      +16     
+ Misses      10759    10753       -6

@codecov
Copy link

codecov bot commented Dec 8, 2018

Codecov Report

Merging #3454 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3454      +/-   ##
==========================================
+ Coverage   83.26%   83.27%   +<.01%     
==========================================
  Files         365      365              
  Lines       64306    64317      +11     
==========================================
+ Hits        53547    53562      +15     
+ Misses      10759    10755       -4

@pavlin-policar pavlin-policar merged commit 6481150 into biolab:master Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants