[FIX] OWDataProjectionWidget: check validity, fix sparse data reloading #3485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VesnaT
changed the title
VesnaT
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3485 +/- ##
==========================================
+ Coverage 83.55% 83.57% +0.02%
==========================================
Files 367 367
Lines 65454 65470 +16
==========================================
+ Hits 54691 54718 +27
+ Misses 10763 10752 -11 |
Codecov Report
@@ Coverage Diff @@
## master #3485 +/- ##
==========================================
+ Coverage 83.55% 83.59% +0.03%
==========================================
Files 368 368
Lines 65772 65807 +35
==========================================
+ Hits 54956 55009 +53
+ Misses 10816 10798 -18 |
VesnaT
changed the title
VesnaT
force-pushed
the
fix_widget_1
branch
2 times, most recently
from
2c86913
to
53dcc22
Compare
janezd
reviewed
Dec 21, 2018
| v2.sort(axis=0) | ||
| return np.allclose(v1, v2, equal_nan=True) | ||
|
|
||
|
|
There was a problem hiding this comment.
@VesnaT, if you agree with this, I agree with the rest (which I do anyway) and one of us can merge this.
markotoplak
reviewed
Jan 4, 2019
|
|
||
| v1 = np.vstack(sp.find(a1)).T | ||
| v2 = np.vstack(sp.find(a2)).T | ||
| if not (sp.issparse(a1) and sp.issparse(a2)): # Any dense: order indices |
There was a problem hiding this comment.
So, sp.find internally sorts if the matrices have has_canonical_format=False, which is False when converting from any sparse matrix. Therefore, sparse matrices currently do not have to be resorted, so your optimization works well. Should we rely on such undocumented behavior, @janezd?
markotoplak
force-pushed
the
fix_widget_1
branch
from
274300b
to
e1ccd4a
Compare
markotoplak
force-pushed
the
fix_widget_1
branch
from
e1ccd4a
to
3939d8b
Compare
markotoplak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description of changes
Includes