[ENH] Label subset #3506
Merged
[ENH] Label subset #3506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3506 +/- ##
==========================================
+ Coverage 83.51% 83.54% +0.02%
==========================================
Files 367 367
Lines 65599 65717 +118
==========================================
+ Hits 54787 54902 +115
- Misses 10812 10815 +3 |
markotoplak
force-pushed
the
label-subset
branch
from
d386e9f to
8bc0b3d
Compare
markotoplak
reviewed
Jan 4, 2019
| np.logical_and(x >= x0, x <= x1), | ||
| np.logical_and(y >= y0, y <= y1)) | ||
| if self.label_only_selected: | ||
| sub_mask = self._filter_visible(self.master.get_subset_mask()) |
There was a problem hiding this comment.
Aaaa, having masks that can be None make the code so ugly... But I did not find a better solution.
Perhaps in the future we could have some helper functions for logical_* where arguments could be None? Or just have masks that are never None?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3376: subsets are similar to selections, so it would make sense to label the subset data instances, too.
Based on #3500 for faster CI testing, but otherwise unrelated. If reviews are positive, I'll rebase to master so it can be merged.
Description of changes
To keep the GUI simple, this PR does not introduce another checkbox, but just adds subset instances to those that are labelled. Checkbox is renamed from Label only selected points to Label only selection and subset.
Includes