[FIX] Neighbours: Show error when data and reference have different domain. #3547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3547 +/- ##
==========================================
+ Coverage 83.78% 83.79% +<.01%
==========================================
Files 370 370
Lines 66680 66717 +37
==========================================
+ Hits 55871 55905 +34
- Misses 10809 10812 +3 |
PrimozGodec
force-pushed
the
fix-neighbour-chrashes
branch
from
86f64ad
to
539832d
Compare
PrimozGodec
changed the title
…hings you people wouldn't believe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Neighbours chrashes when data and reference has different domains.
Description of changes
It shows an error instead of a crash now.
Includes