Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] OWDistances: Use only binary features for Jaccard distance #3569

Merged
merged 1 commit into from
Feb 15, 2019

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Feb 1, 2019

Issue

Fixes #3559.

Description of changes

Other distances are similar and their errors, warnings and selection of attributes is handled through flags. Jaccard is specific, so I have not introduced more new flags to distances (because this flag would be used only for Jaccard, at least for now) but instead added a Jaccard-specific check to the widget.

Includes
  • Code changes
  • Tests

@janezd janezd force-pushed the jaccard-nonbinary branch from 391e5bf to c11b480 Compare February 1, 2019 18:03
@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #3569 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3569      +/-   ##
==========================================
- Coverage   83.97%   83.97%   -0.01%     
==========================================
  Files         370      370              
  Lines       66941    66981      +40     
==========================================
+ Hits        56215    56248      +33     
- Misses      10726    10733       +7

@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #3569 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #3569      +/-   ##
=========================================
+ Coverage      84%     84%   +<.01%     
=========================================
  Files         370     370              
  Lines       67157   67204      +47     
=========================================
+ Hits        56414   56458      +44     
- Misses      10743   10746       +3

@janezd janezd changed the title OWDistances: Use only binary features for Jaccard distance [FIX] OWDistances: Use only binary features for Jaccard distance Feb 2, 2019
@janezd janezd added needs discussion Core developers need to discuss the issue and removed needs discussion Core developers need to discuss the issue labels Feb 15, 2019
@lanzagar lanzagar merged commit f155396 into biolab:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants