-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] DomainEditor: Indicate changed variables with bold face font #3576
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3576 +/- ##
=========================================
- Coverage 84.31% 84.3% -0.01%
=========================================
Files 370 370
Lines 67838 67858 +20
=========================================
+ Hits 57197 57211 +14
- Misses 10641 10647 +6 |
dda2652
to
83854c8
Compare
Does not work correctly for me. |
90c9d22
to
76d6d88
Compare
It's amazing that it worked for me on macOs, but indeed fails on Linux. The problem was in a list that had to be deepcopied, not just copied.
|
LOL, changing feature -> meta of course works. I was observing the output on Select columns, which just reversed any change -- because that's exactly what it does. :) |
76d6d88
to
707a449
Compare
707a449
to
768d8ad
Compare
768d8ad
to
a0d5515
Compare
This works well for me after a short test. However, changes are indicated with italics not bold. I like it that way, but we could make it clear in the PR as well. |
gives italic!? It's bold on my machine. |
Sorry, I was being stupid. I was looking at Edit Domain, I obviously didn't read the PR title well enough. It is indeed in bold. And it works, too. I mean the one in File widget. |
@janezd, I particularly like that reset button. Looks cool. :) |
Issue
Fixes #2673 and fixes #3563.
Description of changes
Model remembers the original data and implements
FontRole
to return a bold font if the line was changed.I sincerely don't know how to reasonably test this. It's all just a game of signals.
Includes