[ENH] PCA: Remove SVD & add normalization for sparse #3581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavlin-policar
force-pushed
the
pca-improvements
branch
from
23b7674
to
fd24edb
Compare
Codecov Report
@@ Coverage Diff @@
## master #3581 +/- ##
=========================================
+ Coverage 83.97% 84% +0.02%
=========================================
Files 370 370
Lines 66976 67042 +66
=========================================
+ Hits 56246 56318 +72
+ Misses 10730 10724 -6 |
Codecov Report
@@ Coverage Diff @@
## master #3581 +/- ##
=========================================
+ Coverage 83.98% 84% +0.01%
=========================================
Files 370 370
Lines 67139 67157 +18
=========================================
+ Hits 56386 56412 +26
+ Misses 10753 10745 -8 |
pavlin-policar
force-pushed
the
pca-improvements
branch
3 times, most recently
from
2db6d91
to
177855c
Compare
pavlin-policar
force-pushed
the
pca-improvements
branch
3 times, most recently
from
a273118
to
cf1746e
Compare
pavlin-policar
force-pushed
the
pca-improvements
branch
from
cf1746e
to
dd447f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Based on #3573, needed so zero-centering can be skipped.
Until recently, PCA didn't support sparse data, so SVD was used instead in the PCA widget. However, PCA now fully supports sparse data, so SVD is no longer necessary.
Description of changes
Includes