[ENH] PCA: Preserve f32s & reduce memory footprint when computing means #3582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
While working towards getting the improved PCA merged into scikit-learn, I've found two improvements.
Description of changes
np.float32
are now preservedx.mean
method isn't the most memory efficient, and scikit-learn's utility functionmean_variance_axis
is much better (see benchmarks here)Includes