[FIX] OWSieve: Fix operators in tooltips #3602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lint is complaining. Will you fix this or do you stand behind your solution? :) |
Codecov Report
@@ Coverage Diff @@
## master #3602 +/- ##
==========================================
- Coverage 83.99% 83.99% -0.01%
==========================================
Files 370 370
Lines 67023 67025 +2
==========================================
- Hits 56298 56296 -2
- Misses 10725 10729 +4 |
Codecov Report
@@ Coverage Diff @@
## master #3602 +/- ##
==========================================
+ Coverage 83.99% 83.99% +<.01%
==========================================
Files 370 370
Lines 67023 67159 +136
==========================================
+ Hits 56298 56413 +115
- Misses 10725 10746 +21 |
|
Let's wait with merge until we resolve what is going on with discretization. |
janezd
added
needs discussion
|
Merging as is. @thocevar Please write an issue for discretization and reference it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3578
Description of changes
Discretization of datasets with mixed attributes does not retain the same instances of discrete attributes. Is this correct behaviour? A check for a discrete attribute with the 'is' operator fails and results in a tooltip such as "gender in male" instead of "gender = male". Revert to an equality check with '=='.
Compress duplicate code for x and y tooltips.
Includes