Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Louvain clustering fails when Table or ndarray on input. #3618

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented Feb 20, 2019

Issue

When Louvain clustering got Orange.Table or ndarray on the input it fails when convertin table to graph.

The way to reproduce:

data = Table("iris")
louvain = Louvain(2)
louvain.fit(data)
Description of changes

Fixed to accept Table or ndarray.
Added tests.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #3618 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3618      +/-   ##
==========================================
+ Coverage   84.07%   84.07%   +<.01%     
==========================================
  Files         370      370              
  Lines       67256    67256              
==========================================
+ Hits        56546    56548       +2     
+ Misses      10710    10708       -2

@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #3618 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3618      +/-   ##
==========================================
+ Coverage   84.07%   84.08%   +<.01%     
==========================================
  Files         370      370              
  Lines       67256    67256              
==========================================
+ Hits        56546    56549       +3     
+ Misses      10710    10707       -3

@janezd janezd merged commit edd3a30 into biolab:master Feb 21, 2019
@PrimozGodec PrimozGodec deleted the fix-louvain branch February 21, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants