Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] k-Means: Output centroid labels #3695

Merged
merged 3 commits into from
Mar 27, 2019

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Mar 22, 2019

Issue

Fixes #3687.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #3695 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3695      +/-   ##
==========================================
+ Coverage   84.49%   84.51%   +0.01%     
==========================================
  Files         373      373              
  Lines       68268    68317      +49     
==========================================
+ Hits        57683    57736      +53     
+ Misses      10585    10581       -4

@lanzagar
Copy link
Contributor

The output table with centroids has no name (was like that before this PR already). Can we think of something (anything) and set that attribute (so that e.g. Source from the Concatenate widget output makes more sense)?
I am fine with any naming scheme, maybe something like:
name (centroids), centroids - name, ...
where name = self.data.name

@janezd janezd force-pushed the kmeans-output-centroid-labels branch from e8c3d48 to 20d04c0 Compare March 26, 2019 18:03
@janezd
Copy link
Contributor Author

janezd commented Mar 26, 2019

I went for "name centroids", for instance "iris centroids".

I didn't write a separate test but just added assertions to existing tests. Test do not mock clustering (I won't add mocking within this PR - I tried but it's not trivial), so separate tests would slow down the testing suite.

@lanzagar lanzagar changed the title Kmeans output centroid labels [ENH] k-Means: Output centroid labels Mar 27, 2019
@lanzagar lanzagar merged commit 10269b5 into biolab:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants