[FIX] Compatibility with Logitech's Smart Move #3702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3702 +/- ##
==========================================
+ Coverage 84.52% 84.52% +<.01%
==========================================
Files 373 373
Lines 68391 68391
==========================================
+ Hits 57805 57806 +1
+ Misses 10586 10585 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3294, #3598
Description of changes
Logitech's Smart Move option moves the mouse pointer to a focused item after opening a new window.
A double-click triggers two mouse press events and a double-click event between them. After the widget window opens, Smart Move triggers a mouse move event. A typical event sequence is [press, release, double click, press, move, release], which results in a relocation of the widget's node on canvas (moved while pressed).
The solution is to ignore the second press event if it is too close (closer than doubleClickInterval) to the previous one.
Includes