Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Transform: Values of primitive variables as feature names #3721

Merged
merged 1 commit into from
Apr 5, 2019

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Apr 4, 2019

Issue

Implements #3677

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #3721 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3721      +/-   ##
==========================================
+ Coverage   84.53%   84.54%   +<.01%     
==========================================
  Files         373      373              
  Lines       68471    68502      +31     
==========================================
+ Hits        57884    57915      +31     
  Misses      10587    10587

@janezd janezd self-assigned this Apr 4, 2019
Copy link
Contributor

@janezd janezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name FROM_META_ATTR became misleading. Maybe rename to FROM_ATTR or FROM_VAR? That is, assuming we also allow non-metas.

Orange/data/table.py Outdated Show resolved Hide resolved
Orange/widgets/data/owtranspose.py Outdated Show resolved Hide resolved
Orange/widgets/data/owtranspose.py Outdated Show resolved Hide resolved
Orange/data/table.py Outdated Show resolved Hide resolved
@janezd janezd removed their assignment Apr 4, 2019
@VesnaT VesnaT force-pushed the transpose_primitive_vars branch 3 times, most recently from cc1b8c2 to 9a15fa0 Compare April 5, 2019 11:58
@janezd
Copy link
Contributor

janezd commented Apr 5, 2019

Knuth would be so proud.

@janezd janezd merged commit b059db4 into biolab:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants