Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] ProjectionWidgetTestMixin: Fix test_plot_once #3738

Merged
merged 1 commit into from
Apr 19, 2019

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Apr 12, 2019

Issue

Fixes #3723

Description of changes

Wait until the widget stops blocking before checking number of calls.

Includes
  • Code changes
  • Tests
  • Documentation

Wait until the widget stops blocking before checking number of calls.
@VesnaT VesnaT requested a review from pavlin-policar April 12, 2019 08:43
@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #3738 into master will decrease coverage by <.01%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##           master    #3738      +/-   ##
==========================================
- Coverage   84.74%   84.74%   -0.01%     
==========================================
  Files         374      374              
  Lines       68574    68591      +17     
==========================================
+ Hits        58113    58126      +13     
- Misses      10461    10465       +4

@pavlin-policar pavlin-policar merged commit f92ed93 into biolab:master Apr 19, 2019
Copy link
Collaborator

@pavlin-policar pavlin-policar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_plot_once is wrong
2 participants