Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Minor improvements to pythagorean trees #3777

Merged
merged 6 commits into from
May 24, 2019

Conversation

pavlin-policar
Copy link
Collaborator

Description of changes

This fixes a couple of minor things I came across while reviewing #3775.

  1. Remember selection in the Pythagorean forest widget so that reopening a workflow won't clear selection.
  2. Remove some dead code from both widgets
  3. Properly use context settings in Pythagorean tree and forest widget (before, it wasn't using the domain context settings handler.
  4. The tree widget would crash if there was no data and we clicked "Redraw".

The tree widget does not currently remember selection (both when reopening a workflow or when redrawing), and this will be a bit trickier to implement, since Orange trees have no identifier for each node.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Apr 27, 2019

Codecov Report

Merging #3777 into master will increase coverage by 0.01%.
The diff coverage is 87.3%.

@@            Coverage Diff             @@
##           master    #3777      +/-   ##
==========================================
+ Coverage   85.04%   85.06%   +0.01%     
==========================================
  Files         374      374              
  Lines       69111    69142      +31     
==========================================
+ Hits        58776    58816      +40     
+ Misses      10335    10326       -9

@thocevar
Copy link
Contributor

There is a problem with the settings of Pythagorean trees that come from a forest. For example, you can set the depth of a tree to 1, then select a different tree and the visualization does not match the depth setting. Similar situation arises when you change the data. The depth is set to the context-aware value but is not reflected in the visualization.

@pavlin-policar
Copy link
Collaborator Author

@thocevar This issue should now be resolved.

@thocevar thocevar merged commit c90d9ce into biolab:master May 24, 2019
@pavlin-policar pavlin-policar deleted the pythagoras-enh branch June 3, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants