Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] VerticalItemDelegate: Do not cut long vertical labels #3803

Merged
merged 1 commit into from
May 27, 2019

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented May 16, 2019

Issue

Long vertical labels (i.e. labels for table's vertical header) are cut off:
Screen Shot 2019-05-15 at 11 17 06

Description of changes

Show the whole label.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #3803 into master will decrease coverage by <.01%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master    #3803      +/-   ##
==========================================
- Coverage   85.06%   85.06%   -0.01%     
==========================================
  Files         374      374              
  Lines       69143    69148       +5     
==========================================
+ Hits        58817    58820       +3     
- Misses      10326    10328       +2

@janezd janezd self-assigned this May 17, 2019
@janezd
Copy link
Contributor

janezd commented May 17, 2019

This seems OK for this particular use case because there is nothing in the cell above and below this one. What if they are not empty? Maybe VerticalItemDelegate should have a flag whether to extend the text outside the cell or not?

@VesnaT VesnaT force-pushed the VerticalItemDelegate branch from b518f06 to 102a2c5 Compare May 27, 2019 06:30
@VesnaT
Copy link
Contributor Author

VesnaT commented May 27, 2019

Done.

@janezd janezd merged commit 4245960 into biolab:master May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants