Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add conditions for all variables, or all numeric or textual variables #3836

Merged
merged 7 commits into from
Jun 7, 2019

Conversation

janezd
Copy link
Contributor

@janezd janezd commented May 30, 2019

Issue

Fixes #2223. Also fixes #3413.

Includes
  • Code changes
  • Tests
  • Documentation

@janezd janezd changed the title [ENH] Add conditions for all variables, or all numeric or textual variables [WIP] [ENH] Add conditions for all variables, or all numeric or textual variables May 30, 2019
@janezd janezd force-pushed the select-rows-any branch 2 times, most recently from afa25f6 to 119afc8 Compare May 30, 2019 19:57
@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #3836 into master will decrease coverage by <.01%.
The diff coverage is 80.59%.

@@            Coverage Diff             @@
##           master    #3836      +/-   ##
==========================================
- Coverage   85.06%   85.05%   -0.01%     
==========================================
  Files         374      375       +1     
  Lines       69148    69253     +105     
==========================================
+ Hits        58821    58904      +83     
- Misses      10327    10349      +22

@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #3836 into master will increase coverage by 0.15%.
The diff coverage is 81.15%.

@@            Coverage Diff             @@
##           master    #3836      +/-   ##
==========================================
+ Coverage   84.77%   84.93%   +0.15%     
==========================================
  Files         374      377       +3     
  Lines       69172    70245    +1073     
==========================================
+ Hits        58640    59662    +1022     
- Misses      10532    10583      +51

@janezd janezd changed the title [WIP] [ENH] Add conditions for all variables, or all numeric or textual variables [ENH] Add conditions for all variables, or all numeric or textual variables May 31, 2019
@ajdapretnar
Copy link
Contributor

I find 🐛 .

Datasets (Forest Fires) - Select Rows (All variables are defined.)

Traceback (most recent call last):  File "/Users/ajda/orange/orange3/Orange/widgets/data/owselectrows.py", line 259, in <lambda>    lambda _: self.set_new_operators(attr_combo, False))  File "/Users/ajda/orange/orange3/Orange/widgets/data/owselectrows.py", line 316, in set_new_operators    self.set_new_values(oper_combo, adding_all, selected_values)  File "/Users/ajda/orange/orange3/Orange/widgets/data/owselectrows.py", line 439, in set_new_values    self.conditions_changed()  File "/Users/ajda/orange/orange3/Orange/widgets/data/owselectrows.py", line 488, in conditions_changed    self.commit()  File "/Users/ajda/orange/orange3/Orange/widgets/gui.py", line 2041, in unconditional_commit    do_commit()  File "/Users/ajda/orange/orange3/Orange/widgets/gui.py", line 2049, in do_commit    commit()  File "/Users/ajda/orange/orange3/Orange/widgets/data/owselectrows.py", line 570, in commit    matching_output = self.filters(self.data)  File "/Users/ajda/orange/orange3/Orange/data/filter.py", line 220, in __call__    return data._filter_values(self)  File "/Users/ajda/orange/orange3/Orange/data/table.py", line 1243, in _filter_values    selection = self._values_filter_to_indicator(filter)  File "/Users/ajda/orange/orange3/Orange/data/table.py", line 1273, in _values_filter_to_indicator    selection = self._filter_to_indicator(f)  File "/Users/ajda/orange/orange3/Orange/data/table.py", line 1349, in _filter_to_indicator    sel *= col_filter(col_idx)  File "/Users/ajda/orange/orange3/Orange/data/table.py", line 1323, in col_filter    return ~np.isnan(col)TypeError: ufunc 'isnan' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''

@janezd
Copy link
Contributor Author

janezd commented May 31, 2019

It should work now.

@ajdapretnar ajdapretnar merged commit 5a5a996 into biolab:master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants